[stable24] Make it possible to insert heif/heic images#2975
Merged
juliusknorr merged 2 commits intostable24from Sep 26, 2022
Merged
[stable24] Make it possible to insert heif/heic images#2975juliusknorr merged 2 commits intostable24from
juliusknorr merged 2 commits intostable24from
Conversation
julien-nc
changed the title
Member
Author
|
/compile |
vinicius73
reviewed
Sep 21, 2022
| <input ref="imageFileInput" | ||
| type="file" | ||
| accept="image/*" | ||
| accept="image/*, image/heic, image/heif" |
Member
Author
There was a problem hiding this comment.
I don't know why but explicit heic/heif mime types have to be added in the
<input>.
They are not shown with image/*.
julien-nc
force-pushed
the
backport/stable24/heic-heif-support
branch
from
131463e to
2919e45
Compare
Member
Author
|
/compile |
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
backport/stable24/heic-heif-support
branch
from
dbc7a38 to
b38d87f
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
juliusknorr
approved these changes
Sep 26, 2022
delete-merged-branch
bot
deleted the
backport/stable24/heic-heif-support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #2972
I don't know why but explicit heic/heif mime types have to be added in the
<input>.They are not shown with
image/*.If such files are inserted and the preview provider is not enabled (or does not work), Text behaves just like if we insert a corrupted image.