Skip to content

fix: remove help entry from action list#3212

Merged
mejo- merged 3 commits intomasterfrom
fix/noid/remove-help-entry-from-action-list
Oct 14, 2022
Merged

fix: remove help entry from action list#3212
mejo- merged 3 commits intomasterfrom
fix/noid/remove-help-entry-from-action-list

Conversation

@vinicius73
Copy link
Member

@vinicius73 vinicius73 commented Oct 13, 2022

Regression from #2664

  • Remove formatting-help from other action list
  • Isolate character count

After

image

Before

image

@vinicius73 vinicius73 added this to the Nextcloud 26 milestone Oct 13, 2022
@vinicius73 vinicius73 force-pushed the fix/noid/remove-help-entry-from-action-list branch from bbe718a to deb8146 Compare October 13, 2022 13:37
@vinicius73 vinicius73 changed the title Remove help entry from action list [fix] remove help entry from action list Oct 13, 2022
@vinicius73 vinicius73 changed the title [fix] remove help entry from action list fix: remove help entry from action list Oct 13, 2022
@vinicius73
Copy link
Member Author

vinicius73 commented Oct 13, 2022

/backport to stable25

mejo-
mejo- requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the formatting help to the action list on purpose after discussing this topic with @jancborchardt 😆. The idea was to always force the formatting help into the three dot menu in order to never have only word/character count there. See 6771397.

What exactly are you trying to fix with this PR @vinicius73?

@vinicius73
Copy link
Member Author

vinicius73 commented Oct 13, 2022 •
edited
Loading

@mejo- As you can see in the print, the formatting help wasn't only in the "three dots" menu.
It also was in the "heading menu".

I've removed it from ActionList.vue (who was generating this side effect)

image
image

mejo-
mejo- approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, makes sense now ❤️

Vinicius Reis added 2 commits October 14, 2022 10:36
@juliusknorr
🩹 formatting-help must only be in extra options
a902b89 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@juliusknorr
♻️ isolate logic of CharacterCount
ee4c21c 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@juliusknorr juliusknorr force-pushed the fix/noid/remove-help-entry-from-action-list branch from deb8146 to ee4c21c Compare October 14, 2022 08:36
@juliusknorr
Copy link
Member

juliusknorr commented Oct 14, 2022

/compile

@nextcloud-command
Compile assets
842d36c 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit 58aa5b1 into master Oct 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/remove-help-entry-from-action-list branch October 14, 2022 09:45
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 14, 2022

The backport to stable25 failed. Please do this backport manually.

@mejo-
Copy link
Member

mejo- commented Oct 14, 2022

/backport a902b89,ee4c21ce3564efce6c735c126d19ba607eab40fd to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 14, 2022
Closed
1 task
@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@mejo- mejo- mejo- approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@vinicius73 @juliusknorr @mejo- @susnux @nextcloud-command