Update @nextcloud/vue-richtext to avoid circular dependency issue#3850
Update @nextcloud/vue-richtext to avoid circular dependency issue#3850
@nextcloud/vue-richtext to avoid circular dependency issue#3850Conversation
baef596 to
778ca94
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
0de8fe4 to
0e06c25
Compare
|
/compile amend |
|
No clue why it fails. |
|
https://github.com/nextcloud/text/actions/runs/4295726255/jobs/7486535732 says: and I suspect this marks So they need to be provided as peer dependencies by whatever uses vue-richtext. |
It does not. They are not even in the 🤷 |
|
Even weirder that the build passes locally without any issues :/ |
|
I can reproduce locally. This happens when text is not inside a server clone. Apparently |
|
I think this is due to the bad tree shaking abilities of web pack. I currently see two workarounds:
|
|
We can also wait for #3859 which is a better fix anyway. |
|
Should be good to close now that #3859 landed, right? |
This issue basically makes it impossible to use
@nextcloud/vue-richtextin a script which also imports@nextcloud/vue>= 7.0.0 (when we introduced the circular dependency).