[stable28] fix(a11y): contrast for active menubar buttons#5171
Merged
juliusknorr merged 4 commits intostable28from Dec 28, 2023
Merged
[stable28] fix(a11y): contrast for active menubar buttons#5171juliusknorr merged 4 commits intostable28from
juliusknorr merged 4 commits intostable28from
Conversation
backportbot-nextcloud
bot
requested review from
JuliaKirschenheuter,
jancborchardt,
juliusknorr,
max-nextcloud and
szaimen
juliusknorr
approved these changes
Dec 28, 2023
Dropdown menus (headings and callouts) are still low contrast. Signed-off-by: Max <max@nextcloud.com>
* Use default (white) text in active buttons in light mode. * Add a 2px margin between menubar buttons to have a bit of spacing when two buttons are active next to each other. Signed-off-by: Max <max@nextcloud.com>
Also fix the computation of the number of slots available Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
juliusknorr
force-pushed
the
backport/5098/stable28
branch
from
8a735a9 to
18fbb0c
Compare
Member
|
Rebased as I reverted the workflow updates which broke some actions we customized and I forgot adjusting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5098