fix(files): workspace implementation

[skjnldsv]

Might require nextcloud/server#53872

Master have received a few fixes, the current workspace implementation wasn't optimal, so I fixed it.

1. Now, the headers are properly ALWAYS mounted
2. We don't need to keep track of the newWorkspaceCreated
3. You can emit a proper files:node:updated to dispatch the fact that the current folder have changed (and update the workspace attributes accordingly)

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.61%. Comparing base (9ea5752) to head (cb3235b).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/views/RichWorkspace.vue	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7418      +/-   ##
==========================================
- Coverage   52.63%   52.61%   -0.02%     
==========================================
  Files         494      494              
  Lines       42296    42284      -12     
  Branches     1088     1088              
==========================================
- Hits        22261    22248      -13     
- Misses      19928    19929       +1     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[max-nextcloud]

Two minor nitpicks - other than that looks great. Thanks for taking care of this so quickly!
❤️

[skjnldsv]

Done @max-nextcloud 👍

[max-nextcloud]

/backport to stable31

[max-nextcloud]

Testing out if this helps with rich workspace tests failing in stable31 lately.

[skjnldsv]

@max-nextcloud seems like when you load an existing workspace, clicking the content doesn't trigger the editor mode anymore 🤔

[max-nextcloud]

@skjnldsv I'll take a look. Thanks for the heads up.

[max-nextcloud]

Seeing this in the console makes me think we do not extend the Vue instance with the l10n functions.

update adding them back removes the error but does not change the behavior.

[skjnldsv]

Ah, nice catch!
Extending the vue with globals is a deprecated behaviour anyway.
I'd suggest always importing on each component to be cleaner :)

[max-nextcloud]

I suspect this broke due to a later change in server. Otherwise i don't see how the cypress tests would have passed as they test editing the workspace.

update: most cypress tests pass locally for me as they create the workspace and then test it. - and that works fine.

💭 thinking out loud
It looks like only the RichTextReader is getting mounted because this.getFileInfo is not getting called as this.hasRichWorkspace is false during onMounted.