Skip to content

Fixed SMB Login Issues #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
violoncelloCH merged 1 commit into from
Oct 5, 2019
Merged

Fixed SMB Login Issues #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/smb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function __construct($host) {
private function tryAuthentication($uid, $password) {
$uidEscaped = escapeshellarg($uid);
$password = escapeshellarg($password);
$command = self::SMBCLIENT.' '.escapeshellarg('//' . $this->host . '/dummy').' -U'.$uidEscaped.'%'.$password;
$command = self::SMBCLIENT.' '.escapeshellarg('//' . $this->host . '/dummy').' -U '.$uidEscaped.'%'.$password;
Copy link

@kesselb kesselb Aug 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://explainshell.com/explain/1/smbclient http://manpages.ubuntu.com/manpages/disco/en/man1/smbclient.1.html make sense 👍

Copy link
Member

@violoncelloCH violoncelloCH Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can you see her that the space is needed?
maybe the safer option would be to use --user=username?

Copy link

@kesselb kesselb Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can you see her that the space is needed?

Added a link with proper information 🙈

Copy link
Member

@violoncelloCH violoncelloCH Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay thank you very much, seems legit :)

$lastline = exec($command, $output, $retval);
if ($retval === 127) {
OC::$server->getLogger()->error(
Expand Down