fix: respect opened sidebar when showing the Viewer#3058
Open
fix: respect opened sidebar when showing the Viewer#3058
Conversation
- some apps might have sidebar open when calling Viewer, so initial state should be considered - this also goes for constantly rendered sidebars with v-show Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- with 'position: fixed' sidebar is ripped out of flex container and main content fills the space before modal is rendered (that is visible to end users) - this also respects having app navigation open/closed (did not test without navigation though) Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
susnux
approved these changes
Feb 2, 2026
Comment on lines
+1430
to
+1438
| .app-navigation ~ #app-content-vue:has(~ #app-sidebar-vue:not([style*="display: none"])) { | ||
| flex-basis: calc(100% - 300px - clamp(300px, 27vw, 500px)); | ||
| } | ||
|
|
||
| #app-content-vue:first-child:has(~ #app-sidebar-vue:not([style*="display: none"])), | ||
| .app-navigation--closed ~ #app-content-vue:has(~ #app-sidebar-vue:not([style*="display: none"])) { | ||
| flex-basis: calc(100% - clamp(300px, 27vw, 500px)); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Styles look expensive. But I do not see a cheaper way
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
Need a force merge here, I guess? |
Contributor
Guess so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: respect opened sidebar when showing the Viewer
fix: maintain app content width when opening Viewer