feat: add test_hybrid snapshot#1029
Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
jfy133
left a comment
There was a problem hiding this comment.
Overall LGTM, I only noticed missing files:
- GenomeBinning/QC/busco_summary.tsv
- GenomeBinning/QC/quast_bin_summary.tsv
- GenomeBinnig/SemiBin2/log/SPAdesHybrid-SemiBin2-minigut.SemiBinRun.log (but covered by other files really)
Other observations:
- There are no
Chopperoutput files when I run the test profile itself, is that expected? There is just an empty directory QC_longreads/samtools/stats/minigut_null.statsthenulllooks funky
|
Hi, I had an issue with the hybrid assembly, see #1031. This test here would not cover it but would need at least 2 samples and |
9bc8996 to
c09ad73
Compare
|
I improved this snapshot addressing everything that came up:
Yeah, by default qc filtered FASTQs are not published, and Chopper only publishes that (not even a log). I enabled the FASTQ publishing, so it's not empty now.
It was using the wrong meta key, it's fixed now I added a new samplesheet with 2 samples with short and long reads, and enabled co-assembly. Without your fix it was failing, but now it's working. |
|
Perfect, thanks! |
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).