Skip to content

feat: add test_hybrid snapshot#1029

Open
dialvarezs wants to merge 10 commits into
nf-core:devfrom
dialvarezs:feat/hybrid-snapshot
Open

feat: add test_hybrid snapshot#1029
dialvarezs wants to merge 10 commits into
nf-core:devfrom
dialvarezs:feat/hybrid-snapshot

Conversation

@dialvarezs
Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

Copy link
Copy Markdown
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I only noticed missing files:

  • GenomeBinning/QC/busco_summary.tsv
  • GenomeBinning/QC/quast_bin_summary.tsv
  • GenomeBinnig/SemiBin2/log/SPAdesHybrid-SemiBin2-minigut.SemiBinRun.log (but covered by other files really)

Other observations:

  • There are no Chopper output files when I run the test profile itself, is that expected? There is just an empty directory
  • QC_longreads/samtools/stats/minigut_null.stats the null looks funky

@dialvarezs dialvarezs linked an issue Apr 29, 2026 that may be closed by this pull request
@d4straub d4straub mentioned this pull request May 4, 2026
11 tasks
@d4straub
Copy link
Copy Markdown
Collaborator

d4straub commented May 4, 2026

Hi,

I had an issue with the hybrid assembly, see #1031. This test here would not cover it but would need at least 2 samples and coassembly_group = true. I tested the solution in #1031 (comment) and RAM requirements were on my laptop still small, so I assume that would work.
The question is, would be extending this test be a solution or rather make a new test? I have the impression a new test would cover only whats done here already and more (i.e. duplicate this test unnecessarily). Therefore I suggest to extend test_hybrid.

@dialvarezs dialvarezs force-pushed the feat/hybrid-snapshot branch from 9bc8996 to c09ad73 Compare May 15, 2026 17:56
@dialvarezs
Copy link
Copy Markdown
Member Author

I improved this snapshot addressing everything that came up:

@jfy133

Files...

  • GenomeBinning/QC/busco_summary.tsv: BUSCO summary is not stable, that's why we're excluding it in the snapthots, but we check that is a valid CSV and that the row count is stable, and also we have bin_summary snapshotted, and BUSCO info is contained there. So I guess it's ok.
  • GenomeBinning/QC/quast_bin_summary.tsv: it was always there
  • GenomeBinnig/SemiBin2/log/SPAdesHybrid-SemiBin2-minigut.SemiBinRun.log (but covered by other files really)
    Other observations. Yep, this is not stable because it has timestamp, but we check that the logs have the finishing line.

There are no Chopper output files when I run the test profile itself, is that expected?

Yeah, by default qc filtered FASTQs are not published, and Chopper only publishes that (not even a log). I enabled the FASTQ publishing, so it's not empty now.

QC_longreads/samtools/stats/minigut_null.stats the null looks funky

It was using the wrong meta key, it's fixed now

@d4straub

I added a new samplesheet with 2 samples with short and long reads, and enabled co-assembly. Without your fix it was failing, but now it's working.

@d4straub
Copy link
Copy Markdown
Collaborator

Perfect, thanks!

Copy link
Copy Markdown
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me actually.
Maybe @jfy133 still finds something missing? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate snapshot for test_hybrid

4 participants