Skip to content

Release 5.4.1#991

Open
dialvarezs wants to merge 47 commits intomainfrom
dev
Open

Release 5.4.1#991
dialvarezs wants to merge 47 commits intomainfrom
dev

Conversation

@dialvarezs
Copy link
Member

Fixed

  • #974 - Re-add accidently removed functionality for using metaSPAdes contigs downstream rather than scaffolds (reported by @Pranjal-Bioinfo, fix by @jfy133)
  • #984 - Fix docs regarding usage of Bin QC tool scores when filtering bins for post-processing (by @dialvarezs, @claude)
  • #987 - Fix several documentation issues (by @dialvarezs)
  • #988 - Fix regarding validation of column long_reads_platform in the input samplesheet (#985 by @vinisalazar)
  • #986 - Fix faulty ALE version YAML loading resulting in a snakeyaml error (by @jfy133)

jfy133 and others added 30 commits February 2, 2026 15:38
The `gtdbtk_min_completeness` and `gtdbtk_max_contamination` parameters
previously described filtering as applying only to BUSCO quality metrics.
However, since v2.5 the pipeline supports multiple bin QC tools (BUSCO,
CheckM, CheckM2) and the filter applies to results from any/all of them.

Update help_text in nextflow_schema.json and descriptions in docs/output.md
to accurately reflect that completeness and contamination filtering works
across all available bin QC tools, not exclusively BUSCO.

Fixes #983

https://claude.ai/code/session_01GFjgJHCGv7Jn9ZEdsVMv8p
Update GTDB-Tk QC documentation to include CheckM and CheckM2
Re-add contigs vs scaffolds metaSPAdes selection
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@github-actions
Copy link

github-actions bot commented Mar 7, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 577048b

+| ✅ 382 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   7 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 5.4.1
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-03-07 13:03:44

Comment on lines +22 to +24
| Tool | Previous version | New version |
| ---- | ---------------- | ----------- |
| | | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Tool | Previous version | New version |
| ---- | ---------------- | ----------- |
| | | |

So people don't think we missd something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants