Skip to content

Topics#252

Draft
fasterius wants to merge 3 commits intodevfrom
topics
Draft

Topics#252
fasterius wants to merge 3 commits intodevfrom
topics

Conversation

@fasterius
Copy link
Contributor

WIP PR for migration to topics.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 59c8a7e

+| ✅ 272 tests passed       |+
!| ❗  14 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-01-30 10:36:22

@nictru
Copy link
Collaborator

nictru commented Jan 30, 2026

Hey, thanks for starting this!

In this pipeline, there is not only the versions where topics make sense, but also some other things.
Throughout the pipeline, we use ch_uns, ch_var, ch_obs, ch_obsm, etc. to collect elements that should be added to the final anndata object. I think these could very well be replaced with topics to make the pipeline code cleaner.

What do you think?

@fasterius
Copy link
Contributor Author

Yes, that might be a good use-case for topics as well, although we'd have to look closer at it. I think that would be separate PR, regardless, as this one focuses of future-proofing the pipeline for upcoming nf-core changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments