initial testdata for nf-core/fastquorum#1200
Merged
nh13 merged 1 commit intonf-core:fastquorumfrom May 11, 2024
Merged
Conversation
jfy133
approved these changes
May 10, 2024
Member
jfy133
left a comment
jfy133
left a comment
There was a problem hiding this comment.
Based on the specifications here: https://nf-co.re/docs/contributing/nfcore_component-specifications/test_data
This overall LGTM. Ideally it would be nice if the FASTQ files were a little smaller (if possible), but otherwise it's within bounds.
Only suggestion is given you've given the commands used to generate data for completeness the versions of seqtk, samtools, and bwa, would be nice (thinking something got nuked and had to be re-generated), but not essential.
nh13
force-pushed
the
fastquorum
branch
2 times, most recently
from
5d71576 to
d8ebba4
Compare
nh13
added a commit
to nf-core/fastquorum
that referenced
this pull request
May 11, 2024
nh13
added a commit
to nf-core/fastquorum
that referenced
this pull request
May 13, 2024
Adding test config with new test-datasets. See: nf-core/test-datasets#1200
nh13
added a commit
to nf-core/fastquorum
that referenced
this pull request
May 13, 2024
Adding test config with new test-datasets. See: nf-core/test-datasets#1200
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.