Update NS_ENUM and Add Swift Package Manager Support#5
Merged
Conversation
danbenner-vega
approved these changes
May 28, 2025
danbenner-vega
left a comment
There was a problem hiding this comment.
Not sure about the "bug" you might have found, but I'm also not concerned with that test you commented most of it out. Approved.
brentvegafederal
approved these changes
May 28, 2025
brentvegafederal
left a comment
There was a problem hiding this comment.
Approved but don't forget to update Package.swift
Contributor
Author
|
@danbenner-vega I left some debug commented code in - (NSBundle *)getBundle {
#if SWIFT_PACKAGE
return SWIFTPM_MODULE_BUNDLE;
#else
return [NSBundle bundleForClass:[SFGFeatureCollectionTestCase class]];
#endif
} |
* Updates all enums to NS_ENUM for Swift interoperability. * Updates tests and github workflows to use SPM
7cab10e to
57dc8ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes all enum using NS_ENUM and adds support for Swift Package Manager (SPM). This is a breaking code change.
ngageoint/simple-features-ios#7