Skip to content

trackRequestResult - aborted requests are cached #542

@citruspress

Description

@citruspress

Which @ngneat/elf-* package(s) are the source of the bug?

requests-cache, requests-status

Is this a regression?

No

Description

When using trackRequestResult with a get request that is immediately cancelled, updateRequestResult isn't called, because observable next(), error() or complete() aren't called.

I'll create a PR where updateRequestResult is called in finalize() (if still status: 'fetching') that should clarify.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw


Please provide the environment you discovered this bug in

"@ngneat/elf": "~2.5.1",
"@ngneat/elf-entities": "~5.0.2",
"@ngneat/elf-requests": "~1.9.2",

Anything else?

No response

Do you want to create a pull request?

Yes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions