fix(store): remove SelectorWithProps and MemoizedSelectorWithProps

[david-shortman]

Remove all deprecated SelectorWithProps and MemoizedSelectorWithProps types
and APIs, deprecated since v12 (#2980). Adds a v21 migration schematic that
removes imports, auto-converts string-key selects, and adds inline TODO comments
at select(selector, props) call sites requiring manual migration. Updates the
migration guide with BEFORE/AFTER examples for factory selectors and a memoized
composition pattern.

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngrx/platform/blob/main/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

Closes #3035

What is the new behavior?

• SelectorWithProps and MemoizedSelectorWithProps types are removed from @ngrx/store
• createSelector overloads accepting selectors with props are removed
• createSelectorFactory overloads returning MemoizedSelectorWithProps are removed
• Store.select() and select() operator no longer accept props or string keys
• defaultStateFn no longer handles the props branch
• Testing utilities (MockStore, MockSelector) no longer reference MemoizedSelectorWithProps
• ESLint rule prefix-selectors-with-select no longer checks for removed types
• Downstream packages updated: router-store service, standalone-app pipe, data test
• A v21 migration schematic:
  • Removes SelectorWithProps/MemoizedSelectorWithProps imports
  • Auto-converts select('key') string-key calls to select((state: any) => state['key'])
  • Adds inline // TODO comments at select(selector, props) call sites that need manual migration
  • Logs warnings to the console for call sites requiring manual migration
• The v21 migration guide documents the breaking change with:
  • Factory selector BEFORE/AFTER pattern
  • Memoized factory pattern (using createSelector to memoize the factory)
  • Note explaining that selectors with props did not memoize properly in practice

Does this PR introduce a breaking change?

[x] Yes
[ ] No

SelectorWithProps, MemoizedSelectorWithProps, and all related overloads have been removed. Users should migrate to factory selectors. Note that selectors with props did not memoize properly in practice — defaultMemoize uses strict reference equality (===), so passing inline object literals as props defeated memoization on every change detection cycle.

BEFORE:

const selectCustomer = createSelector(
  selectCustomers,
  (customers, props: { customerId: number }) => customers[props.customerId]
);
this.store.select(selectCustomer, { customerId: 42 });

AFTER (factory selector):

const selectCustomer = (customerId: number) =>
  createSelector(selectCustomers, (customers) => customers[customerId]);
this.store.select(selectCustomer(42));

AFTER (memoized factory — createSelector memoizes the projector, so repeated calls with the same argument return the same inner selector instance):

const selectCustomer = createSelector(
  (customerId: number) => customerId,
  (customerId) =>
    createSelector(selectCustomers, (customers) => customers[customerId])
);

// selectCustomer(42) returns a memoized selector;
// calling selectCustomer(42) again returns the same instance.
this.store.select(selectCustomer(42));

String-key selectors (this.store.select('featureName')) have also been removed in favor of selector functions.

[netlify]

✅ Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	cfcf051
🔍 Latest deploy log	https://app.netlify.com/projects/ngrx-io/deploys/697cba5ffb7c930008f2e4a0
😎 Deploy Preview	https://deploy-preview-5080--ngrx-io.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[timdeschryver]

This is a big one that needs to be discussed with the team (because it can break many legacy apps).
If it gets accepted the first release that can include this is v22.