WIP Replace request with teeny-request#302
Closed
XhmikosR wants to merge 1 commit intonickmerwin:masterfrom
XhmikosR:teeny-request
Closed
WIP Replace request with teeny-request#302XhmikosR wants to merge 1 commit intonickmerwin:masterfrom XhmikosR:teeny-request
XhmikosR wants to merge 1 commit intonickmerwin:masterfrom
XhmikosR:teeny-request
Conversation
|
https://www.npmjs.com/package/axios could also be a good replacement |
Contributor
Author
|
I'm trying to keep using callbacks and not promises. |
Any particular reason for that? I thought everything is now moving to promises for good |
Contributor
Author
|
The whole codebase is using callbacks, I'm not going to change that myself 😛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft because I could use some help with tests
@nickmerwin if you have any suggestions how to fix the tests to stub
teeny-requestsince it doesn't expose apostfunction let me know 🙂Size comparison:
This is an alternative to #275 with a package that has very close API to request. I'm not sure if v6.0.3 works with Node.js 6.x, but we'll know for sure after we fix the tests.
If merged fixes #204 and closes #275.