feat: Add automated certificate check and renewal workflows #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `check_certs.yml` workflow to validate the presence and validity of distribution certificates, with options to renew or recreate certificates. - Updated `build_trio.yml` to integrate certificate checks as a dependency for the build job. - Enhanced `validate_secrets.yml` with clearer error messages for App Store Connect API authorization issues. - Modified `create_certs.yml` to allow `workflow_call` triggers. - Added `check_and_renew_certificates` lane in Fastlane for certificate validation and renewal.
Contributor
Author
|
This is also PRed to LoopKit/LoopWorkspace: LoopKit/LoopWorkspace#228 This PR might receive updates depending on feedback on the other PR. Please reach out regarding testing on expired certificates, there might be scenarios we'd like to cover. Edit: the workflow seems to be failing, please wait for confirmation that it is worthwhile to test this. |
Contributor
|
The PR up through commit I took the work you provided on LoopKit/LoopWorkspace#228 and modified my own test branch for Trio. I expect you will make a few more tweaks but this is a working version.
|
Contributor
Author
|
Closing this one in favour of a new PR that actually works :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_certs.ymlworkflow to validate the presence and validity of distribution certificates, with options to renew or recreate certificates.build_trio.ymlto integrate certificate checks as a dependency for the build job.validate_secrets.ymlwith clearer error messages for App Store Connect API authorization issues.create_certs.ymlto allowworkflow_calltriggers.check_and_renew_certificateslane in Fastlane for certificate validation and renewal.