-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Streamline build action #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dnzxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't really agree with moving certain parts of what used to be in validate secrets into the build action, but I seem to be the only one bothered by this.
As for the rest I think the changes are sound.
@tmhastings / @MikePlante1 do the changes to testflight.md here need to be brought over to TrioDocs when/before this makes it into dev?



Purpose:
Bring in updates to the build actions from LoopFollow.
The streamlined build method still runs every Sunday and uses the logic that if there are updated commits or if it is the second Sunday of the month, it will trigger a build, otherwise the build is skipped.
The order of operations was modified for efficiency
ubuntu-latestinstead ofmacos-15is chosen where possibleThe alive branches are no longer created or used and can be deleted from people's forks after this update is merged.
Because of the simplification from removing alive branches - the artificial requirement that the fork must have the same name as the upstream repository is removed (although it is still a good idea). In addition, any branch that exists in the upstream repository can be selected as default for the user's fork and will update when the upstream branch is updated.
There were several LoopFollow PR encompassed in this single modification for LoopCaregiver:
Test
Push this branch to the GitHub org: docs-test, make it the default branch and do a test build using GitHub actions.