Solve issue 33 and pymap.xml missing chunk.#47
Merged
licliu merged 3 commits intonima:masterfrom Nov 17, 2022
Merged
Conversation
The bus address should be added to pymap.xml, otherwise the python interface will not know about it. Signed-off-by: Zhongze Hu <joshuahu@tencent.com>
In case 17: dmi_memory_device_extended_size(sect_n, WORD(data + 0x1C)); may cause memory capcity read error. This because WORD and DWORD have different byte size, the DWORD is double long of WORD. After SMBIOS v2.8.0, the structures assume to be little-endian order. So redefine the WORD and DWORD in types.h. Signed-off-by: Zhongze Hu <joshuahu@tencent.com>
licliu
reviewed
Nov 17, 2022
Collaborator
licliu
left a comment
licliu
left a comment
There was a problem hiding this comment.
Since ALIGNMENT_WORKAROUND and BIGENDIAN are merged into one if macro in the new line 76, BIGENDIAN should also be added in line 60's ifdef macro, otherwise U64 will be undefined when only BIGENDIAN is defined.
Since ALIGNMENT_WORKAROUND and BIGENDIAN are merged into one if macro in the new line 76, BIGENDIAN should also be added in line 60's ifdef macro, otherwise U64 will be undefined when only BIGENDIAN is defined. Signed-off-by: Zhongze Hu <joshuahu@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello All:
I am solving the issue 33 WORD and DWORD problem. This problem may cause by mistake, WORD and DWORD have different byte sizes, it may cause wrong memory device capcity in some devices. I also redefine them in types.h file, because after SMBIOS-2.8.0, the structure of data assume to be little-endian order. I tested DWORD and WORD in unit-tests/private/files, the DWORD result is correct and same as dmidecode result. @licliu please help to test this patches, thanks.