Skip to content

Introduce a more thorough clean method#767

Open
niosus wants to merge 1 commit intomasterfrom
better-clean
Open

Introduce a more thorough clean method#767
niosus wants to merge 1 commit intomasterfrom
better-clean

Conversation

@niosus
Copy link
Copy Markdown
Owner

@niosus niosus commented Jan 23, 2022

Before we would only clean cmake cache and that operation would regularly fail due to a bug in the code. This PR allows to clear all internal cache including the temporary folders generated before.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2022

Codecov Report

❌ Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.31%. Comparing base (3b16eb1) to head (58faf01).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
plugin/view_config/view_config_manager.py 16.66% 5 Missing ⚠️
plugin/flags_sources/cmake_file.py 50.00% 2 Missing ⚠️
plugin/utils/tools.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
- Coverage   82.16%   81.31%   -0.86%     
==========================================
  Files          39       39              
  Lines        3319     3328       +9     
==========================================
- Hits         2727     2706      -21     
- Misses        592      622      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant