Visual Studio 2017 warning

[petko]

With release 3.7.0, in VS2017 (15.9.16), I get the following error when using the library in my tests (it is reported as error, but the projects builds OK):

Severity	Code	Description	Project	File	Line	Suppression State
Error (active)	E2512	the argument to a feature-test macro must be a simple identifier	Tests	[path]\json.hpp	1274	

I hope it's not a duplicate, but haven't found it reported..

[t-b]

I'm seeing that as well.

The line in question is

json/single_include/nlohmann/json.hpp

Lines 1270 to 1280 in d187488

	#if \
	(__cplusplus >= 201703L) || \
	((__cplusplus >= 201103L) && JSON_HEDLEY_HAS_CPP_ATTRIBUTE(fallthrough))
	#define JSON_HEDLEY_FALL_THROUGH [[fallthrough]]
	#elif (__cplusplus >= 201103L) && JSON_HEDLEY_HAS_CPP_ATTRIBUTE(clang::fallthrough)
	#define JSON_HEDLEY_FALL_THROUGH [[clang::fallthrough]]
	#elif (__cplusplus >= 201103L) && JSON_HEDLEY_GCC_VERSION_CHECK(7,0,0)
	#define JSON_HEDLEY_FALL_THROUGH [[gnu::fallthrough]]
	#endif
	#endif
	#if !defined(JSON_HEDLEY_FALL_THROUGH)

and that is a verbatim copy from
https://github.com/nemequ/hedley/blob/c395642679d4b79cd54d4f4a3ecb21fdf544513e/hedley.h#L1171-L1181.

So I think that bug should be actually reported to https://github.com/nemequ/hedley.

[nlohmann]

I agree. This issue is not related to this library, but to Hedley.

[nlohmann]

Closed with #1799.