VS2015 compile fail

[aaron3481]

Hi all,

I'm trying to import json.hpp into my project. When compiling, an error came out and pointed to line 8500 "max = static_cast<uint64_t>(std::numeric_limits<number_integer_t>::max()) + 1;"

Error Code: C2589 '(': illegal token on right side of '::'

[nlohmann]

I'll have a look into this. Just to make sure:

• Are you using the most recent version from the develop branch?
• Which version of MSVC are you using?

I'm asking because AppVeyor could execute all tests successfully (https://ci.appveyor.com/project/nlohmann/json) with MSVC 19.0.23918.0.

[Michael-K-GH]

I can confirm that this does happen with the most recent commit in VS2015. This is due to the fact that Windows defines max() and min() as macros in windows.h. You can avoid the macro expansion by surrounding numeric_limits::max in extra parentheses, like so:
max = static_cast<uint64_t>((std::numeric_limits<number_integer_t>::max)()) + 1;

[gregmarr]

You can also add the following to prevent them from being defined, as long as none of your code requires them to be defined, or you can update your code.
#define NOMINMAX

[aaron3481]

Many thanks to all. I will test right the way

[aaron3481]

@nlohmann I'm using VS Community 2015 Version 14.0.23107.0 D14REL and it is the most recent version from the develop branch

[aaron3481]

@Epidal your suggestion fix the issues. Thx
@gregmarr NOMINMAX seems not work

[gregmarr]

You need to define that before including any Windows headers.

[nlohmann]

I committed the fix, but I won't merge it before Travis builds it (there seem to be problems with the LLVM's apt server...)

[nlohmann]

Finally merged commit b508d1f to develop branch.