allow gf (go to file) command also for __() method

[thyseus]

(which is an alias for trans())

[noahfrederick]

Thanks! This addition is welcome, but the proposed code change has a couple problems:

1. It overwrites the original function, so we've lost support for trans() and trans_choice().
2. The new pattern covers a non-existent ___choice() function in addition to __().

Please extend the existing pattern to match __() instead of creating another function. This is also a good opportunity to include test coverage for this functionality. See existing tests for examples.

Let me know if you need further guidance.

[thyseus]

@noahfrederick Yes, i need some guidance. I almost got the regular expression right to also 'listen' on __() - but he is not able to resolve the file properly using my technique. Could you please take a look at b20a49b ? Once this works i want to try to write a test for that myself :)

[noahfrederick]

Sorry for being slow to get around to this! Please see my comment.

[noahfrederick]

Do you want to try adding test coverage? It would involve using vader.vim to make assertions about the output of laravel#goto#filetype_php() and laravel#goto#filetype_blade() when the cursor is on different snippets of PHP code. The tests would look something like:

Before (in a laravel PHP buffer):
  tabedit test/fixtures/laravel-8/app/Example.php
  ...add buffer contents

After (clean up buffer):
  bdelete

Execute (Go to translation file):
  AssertEqual laravel#goto#filetype_php(), 'Elanguage some/path.php'

...

The test suite actually involves running the tests against a new Laravel project. The setup script is here, and you can see how a test like this works here, and you can run the test suite with:

vim -Nu test/fixtures/init.vim -c 'Vader! test/*'

[thyseus]

Yes - i will try in this running week. Awesome that there is a testing suite for vim... :)

[thyseus]

Hey @noahfrederick

i think i am far to the goal, but it seems like the vim instance that vader.vim starts with your instructions does not have the vim-laravel module loaded. Setting the cursor the first a of auth on {{ __('auth.failed'); }} and hitting "gf" does not do what is expected. How can i ensure that the vim-laravel project has been loaded? Doing this steps "manually" without vader.vim does have the expected behavior.

Thanks a lot !

[noahfrederick]

it seems like the vim instance that vader.vim starts with your instructions does not have the vim-laravel module loaded.

That's possible. How are you invoking vader.vim? The test/fixtures/init.vim init file assumes all the required plug-ins are installed to the current working directory. You will probably need to adjust that. Or you could just run the tests using your own vimrc instead, i.e., vim -c 'Vader! test/*'. That's probably easier.

[noahfrederick]

Let's move these new tests to their own test file, tests/goto.vader (matching the autoload script name), since we're testing a different type of functionality.

[noahfrederick]

My understanding is that Before and After blocks are executed again for every test in the test file, so there should only be one of each per file. You can do additional setup for a single test in an Execute block instead.

[noahfrederick]

It's good to exercise the gf mapping at least once, as you have here, but it would also be valuable to test the output of laravel#goto#filetype_php() and laravel#goto#filetype_blade() directly. They output strings that are executed as navigation commands:

  AssertEqual laravel#goto#filetype_blade(), 'Elanguage en/auth'