Replace exception library Should with Chai#29
Merged
HappyZombies merged 3 commits intodevelopmentfrom Oct 12, 2021
Merged
Conversation
jankapunkt
approved these changes
Oct 11, 2021
Member
jankapunkt
left a comment
jankapunkt
left a comment
There was a problem hiding this comment.
I checked it out and ran the tests, coverage and test resluts are exactly the same, besides being 10ms faster :-)
Member
|
@HappyZombies you can take a look at it if you want, from my end it is good to go |
Closed
Member
|
I will look into it further more today and into tomorrow maybe. |
Member
HappyZombies
left a comment
HappyZombies
left a comment
There was a problem hiding this comment.
One question and small indentation. Once resolved I will merge. But looks good on my end too
test/unit/models/token-model_test.js
Outdated
|
|
||
| var model = new TokenModel(data); | ||
| model.accessTokenLifetime.should.be.Number; | ||
| should.exist(model.accessTokenLifetime); |
Member
There was a problem hiding this comment.
Indentation here is off by a bit
Contributor
Author
There was a problem hiding this comment.
oops... I need to set up some workspace setting for this project. It's the only one in which I use spaces ;)
HappyZombies
added
the
dependencies 🔌
Member
|
Looks good! Merging. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #28