security: add ACL check for WebSocket subscriptions #1840
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check WAC read permission before allowing WebSocket subscriptions. This prevents information leakage via notifications to unauthorized users. - Add authorizeSubscription callback for solid-ws - Check ACL read access before allowing subscription - Deny subscription returns 'err <url> forbidden' - Currently treats all WS connections as anonymous (TODO: auth integration) Depends on: nodeSolidServer/node-solid-ws#29 Fixes nodeSolidServer#1334
Contributor
Author
|
For historical context, this issue was first raised in 2015 (#143) and Tim Berners-Lee described it as a "serious bug":
|
Member
|
@melvincarvalho can you recreate your PR to https://github.com/nodeSolidServer/node-solid-server/tree/websocket-acl-check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check WAC read permission before allowing WebSocket subscriptions. This prevents information leakage via notifications to unauthorized users.
Changes
authorizeSubscriptioncallback for solid-wserr <url> forbiddenDependencies
The solid-ws package needs the new
authorizecallback option before this can work.Future enhancement
Currently all WebSocket connections are treated as anonymous for ACL purposes. This still prevents the main vulnerability (anonymous users subscribing to private resources).
Full authenticated WebSocket subscriptions would require either:
This can be added in a follow-up PR.
Fixes #1334