feat(core): Allow GPG parameters and ignore git hooks.

[ShogunPanda]

This PR introduces the follow changes:

1. Add -n when committing votes. This avoids to being unexpectedly blocked by custom hooks.
2. Add CARITAT_GPG_PARAMS environment variable to customize GPG when decrypting the ballot. This is to handle exotic configurations (like mine where the spinner in git node vote was interfering with password prompt)
3. Add CARITAT_SHOW_ERRORS environment variable to explicitly opt-in for errors showing. This is to cleanup the output when decrypting the ballot since all but one promises are expected to fail.

[aduh95]

1. Add -n when committing votes. This avoids to being unexpectedly blocked by custom hooks.

Opened #71 for this.

2. Add CARITAT_GPG_PARAMS environment variable to customize GPG when decrypting the ballot. This is to handle exotic configurations (like mine where the spinner in git node vote was interfering with password prompt)

What additional flag are you passing? Would that need some documentation?

3. Add CARITAT_SHOW_ERRORS environment variable to explicitly opt-in for errors showing. This is to cleanup the output when decrypting the ballot since all but one promises are expected to fail.

I'm not sure about this, especially as it's written, it would hide by default the error output, which could make debugging very hard. I've opened nodejs/node-core-utils#941 so all of stderr can be ignored.

[ShogunPanda]

2. Add CARITAT_GPG_PARAMS environment variable to customize GPG when decrypting the ballot. This is to handle exotic configurations (like mine where the spinner in git node vote was interfering with password prompt)

What additional flag are you passing? Would that need some documentation?

Since I was having issue in typing my password, I went to use file based input with things like:

CARITAT_GPG_PARAMS="--pinentry-mode=loopback --passphrase-file=/tmp/caritat-passphrase"

3. Add CARITAT_SHOW_ERRORS environment variable to explicitly opt-in for errors showing. >This is to cleanup the output when decrypting the ballot since all but one promises are expected to fail.

I'm not sure about this, especially as it's written, it would hide by default the error output, which could make debugging very hard. I've opened nodejs/node-core-utils#941 so all of stderr can be ignored.

That will make the trick.

Do you want me to update this PR to only retain n.2 so we can land this?

[aduh95]

I went to use file based input with things like:

CARITAT_GPG_PARAMS="--pinentry-mode=loopback --passphrase-file=/tmp/caritat-passphrase"

As the GPG docs say, that's "doing things one usually doesn’t want to do", putting your passphrase into a file sounds less than ideal. I'm not too keen of adding a Caritat specific env variable, unless it's some kind of already established convention. Do you know of any program that does that for gpg?
Any reason you prefer doing that over setting GPG_TTY, and/or setup pinentry? Another approach would be to set GPG_BIN to a wrapper script that adds the custom flags before invoking gpg:

#!/bin/sh
exec gpg --pinentry-mode=loopback --passphrase-file=/tmp/caritat-passphrase "$@"

[ShogunPanda]

Yes, creating a custom wrapper and using via GPG_BIN made the trick!
Closing this!