Skip to content

Conversation

@arcanis
Copy link
Contributor

@arcanis arcanis commented May 10, 2025

I believe Corepack shouldn't have any negative impact on projects that aren't configured to use it. It should only be a net positive. Changing a file from the project has negative impacts as it leads to confusion ("why is this file changing?"), frustration ("I need to revert the file after every command!"), and sometimes breakages (pristine checks).

I didn't object much to auto-pinning at the time it was introduced because it was a request made by people from the TSC, and I was interested in compromise seeking. Considering the TSC declined to push Corepack further, I see less value in that and I'd like to revisit this design.

Fixes #485

Closes #552

@aduh95
Copy link
Contributor

aduh95 commented May 10, 2025

Duplicate of #552?

@arcanis
Copy link
Contributor Author

arcanis commented May 10, 2025

Duplicate of #552?

I didn't see it before but yeah, same intent. It supersedes it though; it also updates the tests.

@MikeMcC399
Copy link
Contributor

I would appreciate this PR moving forward!

Just yesterday I had to ask somebody to revert a commit because they had accidently added a Yarn Classic packageManager to a repo that uses npm as package manager.

Removing the default auto-pinning would help prevent these sorts of mistakes.

Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting to see it in newer version of corepack, taking it more close to 1.0.0

@arcanis arcanis merged commit 77fff3c into main May 16, 2025
13 checks passed
@arcanis arcanis deleted the mael/auto-pin-0 branch May 16, 2025 17:14
@crazyair
Copy link

crazyair commented May 25, 2025

How to subscribe to publishing new versions? I want to upgrade as soon as possible

@MikeMcC399 MikeMcC399 mentioned this pull request May 21, 2025
2 tasks
@MikeMcC399

This comment was marked as resolved.

@friederbluemle
Copy link
Contributor

Thank you so much for merging and releasing this. It was driving me nuts that corepack was polluting my legacy Yarn 1 repos by forcibly adding a packageManager in package.json.

@MikeMcC399
Copy link
Contributor

It's been merged into v0.33.0 and the process to roll it out through Node.js bundling has begun. Node.js 24.2.0 has already picked it up, for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

COREPACK_ENABLE_AUTO_PIN should default to 0

7 participants