Skip to content

Fix incorrect registry origin check #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Oct 1, 2025
Merged

Fix incorrect registry origin check #743

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f140e1
fix: registry origin not correct checked
victor-perez Sep 30, 2025
cc952d3
Merge branch 'main' into feature/bug-733
victor-perez Sep 30, 2025
74184d8
Update sources/httpUtils.ts
victor-perez Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sources/httpUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ async function fetch(input: string | URL, init?: RequestInit) {
input.username = input.password = ``;
}

if (input.origin === (process.env.COREPACK_NPM_REGISTRY || DEFAULT_NPM_REGISTRY_URL) && process.env.COREPACK_NPM_TOKEN) {
const registry = new URL(process.env.COREPACK_NPM_REGISTRY || DEFAULT_NPM_REGISTRY_URL);

if (input.origin === registry.origin && process.env.COREPACK_NPM_TOKEN) {
Comment thread
victor-perez marked this conversation as resolved.
Outdated
headers = {
...headers,
authorization: `Bearer ${process.env.COREPACK_NPM_TOKEN}`,
Expand Down
Loading