Closed
Conversation
richardlau
approved these changes
Oct 3, 2019
Member
Contributor
|
My apologies, perhaps I made the #1903 changes on a stale branch. In two hours, I will resend those changes redone on an updated 5.x branch. |
Member
Author
|
@cclauss no that's fine, your PR was against master and it's now got a divergent README so the backport was dirty. I don't know what the intention is for python support or testing on 5.x so I'm leaving it up to you to decide that -- as long as we have little risk of breaking anything and are accurate in the README that will show up for a 5.x version then I'm fine with whatever. |
4 tasks
rvagg
force-pushed
the
rvagg/v5.0.5-proposal
branch
from
0da2df5 to
b8314f7
Compare
Member
Author
|
running CI, https://ci.nodejs.org/job/nodegyp-test-pull-request/161/ and Travis, will tag and release this when green |
Member
Author
rvagg
added a commit
that referenced
this pull request
Oct 4, 2019
rvagg
force-pushed
the
rvagg/v5.0.5-proposal
branch
from
b8314f7 to
1163e9c
Compare
rvagg
force-pushed
the
rvagg/v5.0.5-proposal
branch
from
1163e9c to
034fc90
Compare
Member
Author
|
I think this is final, just waiting for CI, then will push it out |
Member
Author
|
v5.0.5 published |
rvagg
added a commit
that referenced
this pull request
Oct 4, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flushing out the non-semver-major commits for a 5.x release just prior to 6.0.0. Will follow up this release immediately with a 6.0.0
d8a71dced1] - gyp: add __lt__ to MSVSSolutionEntry (João Reis) #1904c169250471] - win: support VS 2017 Desktop Express (João Reis) #19024215054729] - lib: accept Python 3 after Python 2 (Sam Roberts) #19103834156a92] - test: add Python 3.5 and 3.6 tests on Linux (cclauss) #19091196e990d8] - src: update to standard@14 (Rod Vagg) #189953ee7dfe89] - gyp: fix undefined name: cflags --> ldflags (Christian Clauss) #19015871dcf6c9] - src,win: add support for fetching arm64 node.lib (Richard Townsend) #1875@cclauss #1903 won't land cleanly onv5.xand I'm not sure how to handle it. It seems to me that it might be a semver-major? Particularly the README.md portions. Would you mind either labeling that PR as semver-major or creating a new PR for the appropriate changes directly against thev5.xbranch? Let me know if you need any help, if you have trouble maybe you could just tell me what needs to be done.