This repository was archived by the owner on Apr 22, 2023. It is now read-only.
startMaster() no longer supports options.workerFilename, options.args and options.workers#2420
Closed
whiteboardmonk wants to merge 1 commit intonodejs:masterfrom
Closed
startMaster() no longer supports options.workerFilename, options.args and options.workers#2420whiteboardmonk wants to merge 1 commit intonodejs:masterfrom
whiteboardmonk wants to merge 1 commit intonodejs:masterfrom
Conversation
… and options.workers
Member
|
This will be fixed in |
|
fixed in f9a47de |
This was referenced Sep 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking through the code to find a way to specify the workerFilename; seems like from 8652848 onwards the option to specify
options.workerFilename,options.argsandoptions.workerswere removed.Would be nice to remove the related comments from the code as well.