This repository was archived by the owner on Apr 22, 2023. It is now read-only.
allow options without args in fork#2424
Closed
AndreasMadsen wants to merge 5 commits intonodejs:masterfrom
Closed
Conversation
Member
Author
|
@piscisaureus ready to go :) |
This was referenced Sep 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allow use of options without the args argument in
child_process.fork. This arguments was already optional in the code, but.slice(0)would throw an error if someone would dochild_process.fork('child,js', {slient: true}).This patch detect if the second argument is an array and then define the arguments variables.