This repository was archived by the owner on Apr 22, 2023. It is now read-only.
cleanup in test-fs-watch when failing#2425
Closed
AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
Closed
cleanup in test-fs-watch when failing#2425AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
|
Thanks for the report, Andreas. I couldn't take your patch because the root issue is that the test creates files in the wrong directory. It's fixed in 539598b. |
Member
Author
|
Oh, hehe thanks anyway. |
This was referenced Sep 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the test-fs-watch testcase is failling there is still remaining files because
.on('exit')wasn't emitted. This patch remove testfiles also when the testcase fail.