This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Update configure to use options.dest_cpu option and default to host_arch()#2428
Closed
mmoss wants to merge 1 commit intonodejs:masterfrom
mmoss:master
Closed
Update configure to use options.dest_cpu option and default to host_arch()#2428mmoss wants to merge 1 commit intonodejs:masterfrom mmoss:master
mmoss wants to merge 1 commit intonodejs:masterfrom
mmoss:master
Conversation
|
dest-cpu wouldn't be validated with your patch. I've already got a pull request fixing this (#2148) but it covers other stuff too and hasn't been reviewed/merged yet. |
Author
|
None of the path-related optons are validated, and the option expects specific values (unlike host_arch) so I didn't think additional validation was necessary. It's a shame you didn't submit discreet patches since it appears you're pull request has been in limbo for about a month. I'm sure others such as myself will be surprised to find that the documented options don't work "as advertised". |
Author
|
Closing this as a dupe of #2148. |
This was referenced Sep 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the TODO and updated configure so that it actually uses the documented --dest-cpu option.