This repository was archived by the owner on Apr 22, 2023. It is now read-only.
process: expose the zlib version in use in process.versions#2896
Closed
TooTallNate wants to merge 2 commits intonodejs:masterfrom
TooTallNate:process.versions.zlib
Closed
process: expose the zlib version in use in process.versions#2896TooTallNate wants to merge 2 commits intonodejs:masterfrom TooTallNate:process.versions.zlib
TooTallNate wants to merge 2 commits intonodejs:masterfrom
TooTallNate:process.versions.zlib
Conversation
Member
There was a problem hiding this comment.
This will include the system zlib.h if there is one. Probably not what you want.
Author
There was a problem hiding this comment.
Indeed. Looks like we do the same in node_zlib.cc though :(
On Monday, March 12, 2012, Ben Noordhuis <
reply@reply.github.com>
wrote:
@@ -55,6 +55,7 @@
#endif
#include <errno.h>
#include <sys/types.h>
+#include <zlib.h>This will include the system zlib.h if there is one. Probably not what
you want.
Reply to this email directly or view it on GitHub:
https://github.com/joyent/node/pull/2896/files#r548538
We could inadventently be picking up the system zlib header instead of the bundled one or another shared version.
Member
|
Thanks Nathan, landed in 9701f1c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm guessing this was just an oversight :)