This repository was archived by the owner on Apr 22, 2023. It is now read-only.
cluster 2.0 - step 7: kill workers when master dies#2908
Closed
AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
Closed
cluster 2.0 - step 7: kill workers when master dies#2908AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
Conversation
This patch will kill the worker once it has lost its connection with the parent. However if the worker are doing a suicide, other measures will be used.
|
Landed on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch will kill the worker once it has lost its connection with the parent. However if the worker are doing a suicide, other measures will be used.
Related issue: #2060
This feature is highly requested but hasn't been made before now, because it was first with the resent
clustercleanup andchild_process.fork().disconnectsupport it could be made in a simpel way.Actually this remove more code than it add ;p
Note that this patch can land before or after #2740 has landed.
/cc @isaacs, @igorzi
This is about merging in cluster 2.0 (see #2038)