Skip to content

tests: remove common.PORT from shared,master,rr tests #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tarunbatra wants to merge 2 commits into from
Closed

tests: remove common.PORT from shared,master,rr tests #12451

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e27619e
test: remove common.PORT from shared leak test
tarunbatra Apr 16, 2017
9bb25ed
test: remove common.PORT from master,rr tests
tarunbatra Apr 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions test/parallel/test-cluster-shared-leak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ if (cluster.isMaster) {
let conn, worker2;

const worker1 = cluster.fork();
worker1.on('message', common.mustCall(function() {
worker1.on('listening', common.mustCall(function(address) {
worker2 = cluster.fork();
worker2.on('online', function() {
conn = net.connect(common.PORT, common.mustCall(function() {
conn = net.connect(address.port, common.mustCall(function() {
worker1.disconnect();
worker2.disconnect();
}));
Expand Down Expand Up @@ -48,6 +48,4 @@ const server = net.createServer(function(c) {
c.end('bye');
});

server.listen(common.PORT, function() {
process.send('listening');
});
server.listen(0);