deps: define BUILDING_NGHTTP2 during nghttp2 build #15487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define BUILDING_NGHTTP2 in order that NGHTTP2_EXTERN is properly defined when building the nghttp2 static library. Move NGHTTP2_STATICLIB out of node.gyp because it is a property of the nghttp2 static library, not the node executable.
nodejs-github-bot
added
build
cjihrig
approved these changes
Sep 20, 2017
jasnell
approved these changes
Sep 20, 2017
Member
|
Landed in 3c777bb |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 24, 2017
Define BUILDING_NGHTTP2 in order that NGHTTP2_EXTERN is properly defined when building the nghttp2 static library. Move NGHTTP2_STATICLIB out of node.gyp because it is a property of the nghttp2 static library, not the node executable. PR-URL: #15487 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Sep 25, 2017
Define BUILDING_NGHTTP2 in order that NGHTTP2_EXTERN is properly defined when building the nghttp2 static library. Move NGHTTP2_STATICLIB out of node.gyp because it is a property of the nghttp2 static library, not the node executable. PR-URL: #15487 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
Define BUILDING_NGHTTP2 in order that NGHTTP2_EXTERN is properly defined when building the nghttp2 static library. Move NGHTTP2_STATICLIB out of node.gyp because it is a property of the nghttp2 static library, not the node executable. PR-URL: nodejs/node#15487 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define BUILDING_NGHTTP2 in order that NGHTTP2_EXTERN is properly defined
when building the nghttp2 static library.
Move NGHTTP2_STATICLIB out of node.gyp because it is a property of the
nghttp2 static library, not the node executable.
CI: https://ci.nodejs.org/job/node-test-pull-request/10159/