Skip to content

test: add common.fixtures to https-req-split #15801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BruceFletcher wants to merge 3 commits into from
Closed

test: add common.fixtures to https-req-split #15801

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd54119
test: add common.fixtures to https-req-split
Oct 6, 2017
ec9ab4d
test: replaced readFileSync with fixtures.readKey
Oct 6, 2017
3e56bfe
test: fixed linting issues I caused with test-https-req-split
Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/parallel/test-https-req-split.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
if (!common.hasCrypto)
common.skip('missing crypto');

Expand All @@ -33,8 +34,8 @@ const tls = require('tls');
const fs = require('fs');

const options = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`)
key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-cert.pem`)
Copy link
Member

@richardlau richardlau Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fs.readFileSync calls could be replaced with fixtures.readKey.

Copy link
Author

@BruceFletcher BruceFletcher Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, test updated. Do I need to do anything else to update the PR?

};

// Force splitting incoming data
Expand Down