Skip to content

test: refactor parallel/test-tls-delayed-attach #19421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juggernaut451 wants to merge 3 commits into from
Closed

test: refactor parallel/test-tls-delayed-attach #19421

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
950287e
test: refactor parallel/test-tls-delayed-attach
juggernaut451 Mar 17, 2018
1b2c826
More description added & common.mustCall remove while sending data
juggernaut451 Mar 19, 2018
dc6c225
More description added
juggernaut451 Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions test/parallel/test-tls-delayed-attach.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

// Checks tls connection delay while sending and recieving data
Copy link
Copy Markdown
Member

@Trott Trott Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

// This test tries to confirm that a TLS Socket will work as expected even if it
// is created after the original socket has received some data.
//
// Ref: https://github.com/nodejs/node-v0.x-archive/issues/6940
// Ref: https://github.com/nodejs/node-v0.x-archive/pull/6950


const fixtures = require('../common/fixtures');
const assert = require('assert');
const tls = require('tls');
Expand All @@ -37,30 +39,30 @@ const options = {
cert: fixtures.readKey('agent1-cert.pem')
};

const server = net.createServer(function(c) {
const server = net.createServer(common.mustCall((c) => {
setTimeout(function() {
const s = new tls.TLSSocket(c, {
isServer: true,
secureContext: tls.createSecureContext(options)
});

s.on('data', function(chunk) {
s.on('data', (chunk) => {
received += chunk;
});

s.on('end', function() {
s.on('end', common.mustCall(() => {
server.close();
s.destroy();
});
}));
}, 200);
}).listen(0, function() {
const c = tls.connect(this.address().port, {
})).listen(0, common.mustCall(() => {
const c = tls.connect(server.address().port, {
rejectUnauthorized: false
}, function() {
}, () => {
c.end(sent);
});
});
}));

process.on('exit', function() {
process.on('exit', () => {
assert.strictEqual(received, sent);
});