Skip to content

errors: alter ERR_HTTP2_INVALID_CONNECTION_HEADERS #19807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidmarkclements wants to merge 3 commits into from
+5 −3
Closed

errors: alter ERR_HTTP2_INVALID_CONNECTION_HEADERS #19807

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b53ac5c
errors: alter ERR_HTTP2_INVALID_CONNECTION_HEADERS
Apr 4, 2018
a6b9fb4
fixup: address comment
Apr 4, 2018
4fc3cbb
add TypeError checks to unit tests
Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,9 +712,8 @@ E('ERR_HTTP2_HEADER_SINGLE_VALUE',
E('ERR_HTTP2_INFO_STATUS_NOT_ALLOWED',
'Informational status codes cannot be used', RangeError);

// This should probably be a `TypeError`.
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Apr 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please also remove the line break above as all other errors are directly beneath each other.

E('ERR_HTTP2_INVALID_CONNECTION_HEADERS',
'HTTP/1 Connection specific headers are forbidden: "%s"', Error);
'HTTP/1 Connection specific headers are forbidden: "%s"', TypeError);
E('ERR_HTTP2_INVALID_HEADER_VALUE',
'Invalid value "%s" for header "%s"', TypeError);
E('ERR_HTTP2_INVALID_INFO_STATUS',
Expand Down