Skip to content

test: add test for a vm indexed property #23318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
conectado wants to merge 4 commits into from
Closed

test: add test for a vm indexed property #23318

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e2f2e8
test: add test for a vm indexed property
conectado Oct 7, 2018
a815617
test: improves indexed properties test by comparing object descriptors
conectado Oct 7, 2018
7171a49
update make it explicit that we are accessing an indexed property
conectado Oct 7, 2018
c2fd550
test: add comment explaining components tested
conectado Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/parallel/test-vm-context-property-forwarding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,9 @@ assert.strictEqual(vm.runInContext('x;', ctx), 3);
vm.runInContext('y = 4;', ctx);
assert.strictEqual(sandbox.y, 4);
assert.strictEqual(ctx.y, 4);

const x = vm.createContext({ get a() { return 5; } });

assert.strictEqual(x.a, 5);
Copy link
Member

@jdalton jdalton Oct 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does IndexedPropertyGetterCallback apply for properties returning index values or indexed properties?

Reflect.defineProperty(x, '1', { get() { return 2 } })

Copy link
Contributor Author

@conectado conectado Oct 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested that scenario and in fact, x[1] === 2. If that's the question. I'm not sure I quite understand it.

delete x.a;
assert.strictEqual(x.a, undefined);