Skip to content

lib: migrating process.binding to getOptions in default_resolve.js #23526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonnyk20 wants to merge 4 commits into from
Closed

lib: migrating process.binding to getOptions in default_resolve.js #23526

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41c5fa2
Migrating process.binding('config') to getOptions() in default_resolv…
jonnyk20 Oct 12, 2018
8ad947e
Revert "Migrating process.binding('config') to getOptions() in defaul…
jonnyk20 Oct 12, 2018
6feadd7
Migrating process.binding('config') to getOptions() in default_resolv…
jonnyk20 Oct 12, 2018
693bf52
Removing git diff from getOptions call
jonnyk20 Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/internal/modules/esm/default_resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ const internalFS = require('internal/fs/utils');
const { NativeModule } = require('internal/bootstrap/loaders');
const { extname } = require('path');
const { realpathSync } = require('fs');
const preserveSymlinks = !!process.binding('config').preserveSymlinks;
const preserveSymlinksMain = !!process.binding('config').preserveSymlinksMain;
const { getOptions } = internalBinding('options');
const preserveSymlinks = !!getOptions('--preserve-symlinks');
Copy link
Copy Markdown
Member

@devsnek devsnek Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the !!, getOptions already returns true/false

Copy link
Copy Markdown
Contributor Author

@jonnyk20 jonnyk20 Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed now!

const preserveSymlinksMain = !!getOptions('--preserve-symlinks-main');
const {
ERR_MISSING_MODULE,
ERR_MODULE_RESOLUTION_LEGACY,
Expand Down