Skip to content

test: correct order of assert args in client response domain test #23604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sheminusminus wants to merge 2 commits into from
Closed

test: correct order of assert args in client response domain test #23604

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5244e5
test: correct order of assert args in client response domain test
sheminusminus Oct 12, 2018
8f4353e
replace onerror callback with arrow function
sheminusminus Oct 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-http-client-response-domain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ server.listen(common.PIPE, function() {
function test() {

d.on('error', common.mustCall(function(err) {

@gireeshpunathil gireeshpunathil Oct 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheminusminus - just a suggestion: if you like, you could also replace this call back (function(err)...) into an arrow function ((err) => .. ) if you like, but feel free to ignore

@sheminusminus sheminusminus Oct 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gireeshpunathil made the update!

assert.strictEqual('should be caught by domain', err.message);
assert.strictEqual(err.message, 'should be caught by domain');
}));

const req = http.get({
Expand Down