Skip to content

doc: improve WHATWG url constructor code example #32782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lirantal wants to merge 3 commits into from
Closed

doc: improve WHATWG url constructor code example #32782

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7f223e
doc: improve WHATWG url constructor code example
lirantal Apr 11, 2020
df1e5b9
chore: update url constructor example
lirantal Apr 20, 2020
6d5f393
fix: missing lang-code for markdown
lirantal Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/api/url.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ WHATWG URL's `origin` property includes `protocol` and `host`, but not
Parsing the URL string using the WHATWG API:

```js
const URL = require('url').URL
Copy link
Copy Markdown
Member

@jasnell jasnell Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that URL is global, this is not strictly required. This might be improved by explaining that distinction?

Copy link
Copy Markdown
Member Author

@lirantal lirantal Apr 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it works global :)
I'm thinking out loud in this PR whether we want to promote that or not and yes to make one or the other more explicit so devs are aware.

const myURL =
new URL('https://user:pass@sub.example.com:8080/p/a/t/h?query=string#hash');
```
Expand Down