process: deprecate multipleResolves #41872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the process multipleResolves event to detect when a promise is resolved more than once because it never really worked. Fixes: nodejs#41554
benjamingr
force-pushed
the
dep-multiple-resolves
branch
from
5a9a60c to
c7b9660
Compare
mscdex
reviewed
Feb 6, 2022
Co-authored-by: mscdex <[email protected]>
RaisinTen
approved these changes
Feb 6, 2022
RaisinTen
added
deprecations
jasnell
approved these changes
Feb 6, 2022
juanarbol
approved these changes
Feb 6, 2022
Mesteery
approved these changes
Feb 6, 2022
benjamingr
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 1f17592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the process multipleResolves event to detect when a promise is
resolved more than once because it never really worked.
Fixes: #41554
Start with a doc-deprecation but I would prefer to follow up with a semver-major runtime warning