src: fixed a small inconsistency between a check and error#515
Closed
toastynerd wants to merge 1 commit intonodejs:v1.xfrom
toastynerd:fix-small-inconsistency
Closed
src: fixed a small inconsistency between a check and error#515toastynerd wants to merge 1 commit intonodejs:v1.xfrom toastynerd:fix-small-inconsistency
toastynerd wants to merge 1 commit intonodejs:v1.xfrom
toastynerd:fix-small-inconsistency
Conversation
Member
|
LGTM but can you update the commit log per the guidelines in CONTRIBUTING.md? The subsystem for changes to src/ is (usually) |
Contributor
Author
|
Ahh, okay, I'll update. I was wondering about that, thanks. |
toastynerd
changed the title
rvagg
pushed a commit
that referenced
this pull request
Jan 20, 2015
dlopen takes exactly 2 arguments, check for exactly 2 PR-URL: #515 Reviewed-By: Rod Vagg <rod@vagg.org>
Member
|
minor commit msg edits, landed in 9419e1f, thanks @toastynerd! |
This was referenced Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was digging through the source and noticed this pretty trivial inconsistency between the check that's made and the error that's thrown in DLOpen and thought it would be good practice for going through the contribution process.