lib: refactor SubtleCrypto experimental warnings #54620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
avivkeller
added
experimental
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54620 +/- ##
==========================================
- Coverage 87.34% 87.30% -0.04%
==========================================
Files 649 649
Lines 182602 182742 +140
Branches 35032 35035 +3
==========================================
+ Hits 159493 159547 +54
- Misses 16393 16462 +69
- Partials 6716 6733 +17
|
aduh95
reviewed
Aug 29, 2024
aduh95
reviewed
Aug 29, 2024
panva
force-pushed
the
refactor-experimental-webcrypto-algos
branch
from
0faf147 to
4199147
Compare
aduh95
approved these changes
Aug 29, 2024
panva
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
anonrig
approved these changes
Aug 30, 2024
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 64bb5f8 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for eventual merge of Curve25519 into the main spec (which will make Ed25519 and X25519 stable but leave Curve448 experimental) as well as future introduction of more experimental algorithms this PR neatly organizes experimental algorithms in the code path of
normalizeAlgorithmand ensures their experimental warnings are not called from all over their implementation.Also removeskHashTypeswhich is no longer used.