Skip to content

stream: validate undefined sizeAlgorithm in WritableStream #56067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 20, 2024
Merged

stream: validate undefined sizeAlgorithm in WritableStream #56067

nodejs-github-bot merged 1 commit into from
Dec 20, 2024

Conversation

@jazelly
Copy link
Member

@jazelly jazelly commented Nov 29, 2024 •
edited
Loading

No test was added since it was covered by existing WPT, and the spec change did not introduce WPT updates

Fixes: #56014
Refs: whatwg/streams#1333

@jazelly jazelly added web streams web-standards Issues and PRs related to Web APIs labels Nov 29, 2024
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 29, 2024
@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@jazelly jazelly removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (4cf6fab) to head (fce3fd9).
Report is 152 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56067   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files         656      656           
  Lines      188988   188997    +9     
  Branches    35992    35991    -1     
=======================================
+ Hits       166315   166324    +9     
+ Misses      15838    15832    -6     
- Partials     6835     6841    +6
Files with missing lines Coverage Δ
lib/internal/webstreams/writablestream.js 99.85% <100.00%> (+<0.01%) ⬆️

... and 27 files with indirect coverage changes

@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 29, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/63763/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2024 •
edited by jazelly
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/63812/ 💛

lpinca
lpinca approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 16, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit 57b21b1 into nodejs:main Dec 20, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2024

Landed in 57b21b1

@github-actions github-actions bot mentioned this pull request Jan 3, 2025
Merged
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Merged
@daeyeon daeyeon mentioned this pull request Mar 2, 2025
Merged
@marco-ippolito marco-ippolito mentioned this pull request Mar 6, 2025
Merged
This was referenced Mar 17, 2025
Merged
Merged
Merged
Merged
This was referenced Apr 2, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. web streams web-standards Issues and PRs related to Web APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Streams: writableStreamDefaultControllerGetChunkSize undefined strategy case slightly broken

4 participants

@jazelly @nodejs-github-bot @lpinca @jakecastelli