Skip to content

tools: enable linter in test/fixtures/source-map/output #57700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 7 commits into from
Apr 4, 2025
+10 −2
Merged

tools: enable linter in test/fixtures/source-map/output #57700

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08928b4
tools: enable linter in `test/fixtures/source-map/output`
aduh95 Mar 31, 2025
2d224f4
fixup! tools: enable linter in `test/fixtures/source-map/output`
aduh95 Apr 1, 2025
fca609d
fixup! fixup! tools: enable linter in `test/fixtures/source-map/output`
aduh95 Apr 1, 2025
d7618de
fixup! fixup! fixup! tools: enable linter in `test/fixtures/source-ma…
aduh95 Apr 1, 2025
3aaf5ac
Merge branch 'main' into lint-source-map-output
aduh95 Apr 4, 2025
eb3dbad
Update eslint.config.mjs
aduh95 Apr 4, 2025
5944bf6
Merge branch 'main' into lint-source-map-output
aduh95 Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ export default [
// We want to lint only a few specific fixtures folders
'test/fixtures/*',
'!test/fixtures/console',
'!test/fixtures/source-map',

This comment was marked as off-topic.

Sign in to view

'test/fixtures/source-map/*',
'!test/fixtures/source-map/output',
'!test/fixtures/v8',
'!test/fixtures/vm',
]),
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/source-map/output/source_map_enabled_by_api_node_modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ try {
require('../node_modules/error-stack/enclosing-call-site-min.js').simpleErrorStack();
} catch (e) {
console.log(e);
}
}
2 changes: 1 addition & 1 deletion test/fixtures/source-map/output/source_map_prepare_stack_trace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Error.stackTraceLimit = 5;
assert.strictEqual(typeof Error.prepareStackTrace, 'function');
const defaultPrepareStackTrace = Error.prepareStackTrace;
Error.prepareStackTrace = (error, trace) => {
trace = trace.filter(it => {
trace = trace.filter((it) => {
return it.getFunctionName() !== 'functionC';
});
return defaultPrepareStackTrace(error, trace);
Expand Down
13 changes: 8 additions & 5 deletions test/fixtures/source-map/output/source_map_throw_async_stack_trace.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
// Flags: --enable-source-maps
import '../../../common/index.mjs';
async function Throw() {
await 0;
throw new Error('message');
await 0;
throw new Error('message');
}
// eslint-disable-next-line node-core/async-iife-no-unused-result
(async function main() {
await Promise.all([0, 1, 2, Throw()]);
await Promise.all([0, 1, 2, Throw()]);
})();
// To recreate:
//
// npx --package typescript tsc --module nodenext --target esnext --outDir test/fixtures/source-map/output --sourceMap test/fixtures/source-map/output/source_map_throw_async_stack_trace.mts
//# sourceMappingURL=source_map_throw_async_stack_trace.mjs.map
// npx --package typescript tsc --module nodenext --target esnext \
// --outDir test/fixtures/source-map/output \
// --sourceMap test/fixtures/source-map/output/source_map_throw_async_stack_trace.mts
// # sourceMappingURL=source_map_throw_async_stack_trace.mjs.map
5 changes: 4 additions & 1 deletion test/fixtures/source-map/output/source_map_throw_async_stack_trace.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@ async function Throw() {
throw new Error('message')
}

// eslint-disable-next-line node-core/async-iife-no-unused-result
(async function main() {
await Promise.all([0, 1, 2, Throw()]);
})()

// To recreate:
//
// npx --package typescript tsc --module nodenext --target esnext --outDir test/fixtures/source-map/output --sourceMap test/fixtures/source-map/output/source_map_throw_async_stack_trace.mts
// npx --package typescript tsc --module nodenext --target esnext
// --outDir test/fixtures/source-map/output
// --sourceMap test/fixtures/source-map/output/source_map_throw_async_stack_trace.mts
12 changes: 7 additions & 5 deletions test/fixtures/source-map/output/source_map_throw_construct.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
// Flags: --enable-source-maps
import '../../../common/index.mjs';
class Foo {
constructor() {
throw new Error('message');
}
constructor() {
throw new Error('message');
}
}
new Foo();
// To recreate:
//
// npx --package typescript tsc --module nodenext --target esnext --outDir test/fixtures/source-map/output --sourceMap test/fixtures/source-map/output/source_map_throw_construct.mts
//# sourceMappingURL=source_map_throw_construct.mjs.map
// npx --package typescript tsc --module nodenext --target esnext
// --outDir test/fixtures/source-map/output
// --sourceMap test/fixtures/source-map/output/source_map_throw_construct.mts
// # sourceMappingURL=source_map_throw_construct.mjs.map
Loading