Skip to content

tools: enable linter in test/fixtures/errors #57701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 4 commits into from
Apr 4, 2025
Merged

tools: enable linter in test/fixtures/errors #57701

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc1485a
tools: enable linter in `test/fixtures/errors`
aduh95 Mar 31, 2025
1c91671
fixup! tools: enable linter in `test/fixtures/errors`
aduh95 Apr 1, 2025
60990d5
fixup! fixup! tools: enable linter in `test/fixtures/errors`
aduh95 Apr 2, 2025
9e81b22
Merge branch 'main' into lint-errors-output
aduh95 Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export default [
// We want to lint only a few specific fixtures folders
'test/fixtures/*',
'!test/fixtures/console',
'!test/fixtures/errors',
'!test/fixtures/v8',
'!test/fixtures/vm',
]),
Expand Down
3 changes: 2 additions & 1 deletion test/fixtures/errors/force_colors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
throw new Error('Should include grayed stack trace')
'use strict';
throw new Error('Should include grayed stack trace');
2 changes: 1 addition & 1 deletion test/fixtures/errors/throw_in_eval_anonymous.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ eval(`

throw new Error('error in anonymous script');

`)
`);
2 changes: 1 addition & 1 deletion test/fixtures/errors/throw_in_eval_named.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions test/fixtures/errors/throw_in_line_with_tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* eslint-disable indent, no-tabs */

'use strict';
require('../../common');

console.error('before');

(function() {
// These lines should contain tab!
// eslint-disable-next-line no-throw-literal
throw ({ foo: 'bar' });
// These lines should contain tab!
// eslint-disable-next-line no-throw-literal
throw ({ foo: 'bar' });
})();

console.error('after');
Loading