Skip to content

src: add DCHECK_EQ for Object::New calls #57943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Apr 22, 2025
Merged

src: add DCHECK_EQ for Object::New calls #57943

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3677ec4
src: add dcheck_eq for Object::New constructor calls
JonasBa Apr 20, 2025
a5e1ac0
Update src/node_sqlite.cc
JonasBa Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/node_sqlite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1957,6 +1957,7 @@ void StatementSync::All(const FunctionCallbackInfo<Value>& args) {
row_values.emplace_back(val);
}

DCHECK_EQ(row_keys.size(), row_values.size())
Comment thread
JonasBa marked this conversation as resolved.
Outdated
Local<Object> row_obj = Object::New(
isolate, Null(isolate), row_keys.data(), row_values.data(), num_cols);
rows.emplace_back(row_obj);
Expand Down Expand Up @@ -2061,6 +2062,7 @@ void StatementSync::Get(const FunctionCallbackInfo<Value>& args) {
values.emplace_back(val);
}

DCHECK_EQ(keys.size(), values.size());
Local<Object> result = Object::New(
isolate, Null(isolate), keys.data(), values.data(), num_cols);

Expand Down Expand Up @@ -2409,6 +2411,7 @@ void StatementSyncIterator::Next(const FunctionCallbackInfo<Value>& args) {
if (iter->done_) {
LocalVector<Value> values(isolate,
{Boolean::New(isolate, true), Null(isolate)});
DCHECK_EQ(values.size(), keys.size());
Local<Object> result = Object::New(
isolate, Null(isolate), keys.data(), values.data(), keys.size());
args.GetReturnValue().Set(result);
Expand All @@ -2422,6 +2425,7 @@ void StatementSyncIterator::Next(const FunctionCallbackInfo<Value>& args) {
sqlite3_reset(iter->stmt_->statement_);
LocalVector<Value> values(isolate,
{Boolean::New(isolate, true), Null(isolate)});
DCHECK_EQ(values.size(), keys.size());
Local<Object> result = Object::New(
isolate, Null(isolate), keys.data(), values.data(), keys.size());
args.GetReturnValue().Set(result);
Expand Down Expand Up @@ -2454,11 +2458,13 @@ void StatementSyncIterator::Next(const FunctionCallbackInfo<Value>& args) {
row_values.emplace_back(val);
}

DCHECK_EQ(row_keys.size(), row_values.size());
row_value = Object::New(
isolate, Null(isolate), row_keys.data(), row_values.data(), num_cols);
}

LocalVector<Value> values(isolate, {Boolean::New(isolate, false), row_value});
DCHECK_EQ(keys.size(), values.size());
Local<Object> result = Object::New(
isolate, Null(isolate), keys.data(), values.data(), keys.size());
args.GetReturnValue().Set(result);
Expand All @@ -2477,6 +2483,8 @@ void StatementSyncIterator::Return(const FunctionCallbackInfo<Value>& args) {
LocalVector<Name> keys(isolate, {env->done_string(), env->value_string()});
LocalVector<Value> values(isolate,
{Boolean::New(isolate, true), Null(isolate)});

DCHECK_EQ(keys.size(), values.size());
Local<Object> result = Object::New(
isolate, Null(isolate), keys.data(), values.data(), keys.size());
args.GetReturnValue().Set(result);
Expand Down
Loading